Set up database and import dataset #55
Conversation
|
@agnesas Denne er til deg :) |
There was a problem hiding this comment.
The importer runs successfully on the group VM, and npm run typecheck passes. I also verified that the database row counts match the import summary.
One thing worth investigating before merging: npm audit reports 11 dependency vulnerabilities, including one critical issue through transitive dependencies of pokemon-showdown. I would avoid npm audit fix --force, since it proposes a breaking downgrade. Could we check whether compatible updates are available?
There are also two small documentation issues: the incomplete “Setting up the” heading and the difference between the example database name (mydb) and the default (pokemon).
|
The packages with issues have been overridden individually. This should resolve the issues. I have manually tested that it works as expected. The documentation uses mydb intentionally. This is to be more general, as it does not matter what the production name of the db is, it will just be whatever is in the .env file. However I did add en underscore ( |
Description
I have created a script to import, and update the dataset from Pokemon Showdown. It is broken down into three parts:
A lot of the boilerplate of this import process has been aided by Claude Opus 5.5. Every single AI assisted line has been read and approved.
As a part of this PR I have also created
schema.sqland some general database connection boilerplate. While I recognize that in an ideal world we would have done this in a separate PR, I felt the need to do it this way to make sure the code actually ran like I expected.Unit tests are currently missing, might be added after Vitest is set up depending on whether we find it necessary.
Issue